svn commit: r308424 - head/sys/arm/broadcom/bcm2835
Hans Petter Selasky
hps at selasky.org
Mon Nov 7 19:27:15 UTC 2016
On 11/07/16 20:23, Oleksandr Tymoshenko wrote:
>
>> On Nov 7, 2016, at 10:27 AM, Hans Petter Selasky <hps at selasky.org> wrote:
>>
>> On 11/07/16 18:38, Oleksandr Tymoshenko wrote:
>>> + bcm2835_audio_unlock(sc);
>>> + cv_signal(&sc->worker_cv);
>>
>>
>> Shouldn't cv_signal() be done locked, so that you don't loose any transactions? CV's only wakeup the treads that are sleeping right there and then.
>
> Hi Hans,
>
> In this case it doesn’t matter. bcm2835_audio_xxx lock functions are used to keep channel state consistent. The actual audio hw reprogramming happens in worker thread which only picks up latest state of the virtual channel, there is no need to run every transaction in sequence.
>
Hi,
It is not about running in sequence, but that if the worker thread is
not sleeping, but on the way to sleep, it will never get woken up unless
you use proper locks here!
--HPS
More information about the svn-src-head
mailing list