svn commit: r308181 - in head: . share/mk

[Antoine Brodin]

On Wed, Nov 2, 2016 at 7:53 AM, Dimitry Andric <dim at freebsd.org> wrote:
> On 02 Nov 2016, at 08:25, Jonathan Anderson <jonathan at FreeBSD.org> wrote:
>>
>> On 1 Nov 2016, at 21:10, Dimitry Andric wrote:
>>
>>> Please note, I reverted r307823 (which changed the suffixes from .bco
>>> and .llo to .bc and .ll) in r308003, since it caused a number of ports
>>> failures.  These ports were already using .ll as a suffix for C++ lex
>>> scripts.
>>
>> The changes to bsd.suffixes-posix.mk (included by sys.mk) would have affected anything compiled with bmake, and indeed, I'd imagine that adding a .c->.ll rule alongside .c->.o could cause problems with C++ lex rules. In fact, part of brooks' original motivation for introducing .llo suffixes was to avoid name conflicts (although conflicts with program IR like we're introducing in this commit). The changes in this commit should only be picked up by things that explicit include bsd.{lib,prog}.mk, however, and they also have slightly more esoteric names (e.g., progname.full.ll) that are less likely to cause a conflict. Perhaps I ought to have done an exp-run, but I suspect that this commit will cause much less / no fallout. I don't suppose you have a list of the ports that failed after your r307823 change so that I could do spot checks?
>
> Hi Antoine, you pointed me at some of these port failures due to the .ll
> change, do you still have a list of them?

The failures were:

http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/super-smack-1.3_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/dprog-0.3.1_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/ebnf2yacc-0.1.1.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/gnuchess-6.2.3.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/bugle-0.0.20100508_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/hfst-3.8.2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/grap-1.45.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/g-cows-1.12.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307951/logs/worker-3.8.4.log

Antoine