svn commit: r299496 - head/contrib/atf/atf-c/detail

Conrad E. Meyer cem at FreeBSD.org
Wed May 11 23:39:41 UTC 2016


Author: cem
Date: Wed May 11 23:39:39 2016
New Revision: 299496
URL: https://svnweb.freebsd.org/changeset/base/299496

Log:
  atf map: Fix double-free in low memory error path
  
  If atf_list_append(, X, ) fails, X is freed.  Don't free it again.
  
  If anyone wants to walk this patch upstream, be my guest.  I literally cannot
  upstream it myself due to Google's stupid CLA.
  
  Reported by:	Coverity
  CID:		979936
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/contrib/atf/atf-c/detail/map.c

Modified: head/contrib/atf/atf-c/detail/map.c
==============================================================================
--- head/contrib/atf/atf-c/detail/map.c	Wed May 11 23:25:59 2016	(r299495)
+++ head/contrib/atf/atf-c/detail/map.c	Wed May 11 23:39:39 2016	(r299496)
@@ -360,7 +360,6 @@ atf_map_insert(atf_map_t *m, const char 
             if (atf_is_error(err)) {
                 if (managed)
                     free(value);
-                free(me);
             }
         }
     } else {


More information about the svn-src-head mailing list