svn commit: r301777 - head/lib/libc/stdio

[Pedro Giffuni]

On 06/10/16 07:19, Andrey Chernov wrote:
> On 10.06.2016 15:03, Pedro Giffuni wrote:
>> (Sorry I have been offline/sleep for a while)
>>
>> Hello;
>>
>> I cannot back this out because of this report:
>>
>> http://docs.freebsd.org/cgi/mid.cgi?20160608132224.GA15454
>>
>> This change only re-states what has been working before the ABI breakage
>> fix in r301461.
>
> Because now strcoll_l() is used as before and it is broken in wide char
> converting process. It is broken for _all_, not just for vfscanf()
> ranges. It should never fail with any args.
> Real fix should be in strcoll_l().
>

Yes, it is broken as before however the objective of r301461 was only
to address the ABI breakage. If I revert r301777 then I have to backout
r301461 too, and then we have again the ABI breakage.

I understand you want to fix all but we are under code freeze and
I have to go back to a known working (although still broken) state.

>> The fix to regex is completely independent.
>
> It is dependent. vfscanf() and regcomp() use the same code for range
> collation. If we remove range collation from everywhere, we save
> vfscanf(), but strcoll_l() remains broken.
>
>

We have had a broken regex for a very long time, and we new that
before collation was introduced. I didn't take that decision but
moving to libtre was a lot more work and we really had to have
collation now.

Pedro.