svn commit: r295759 - head/sys/cam/scsi

Warner Losh imp at FreeBSD.org
Thu Feb 18 15:12:53 UTC 2016


Author: imp
Date: Thu Feb 18 15:12:52 2016
New Revision: 295759
URL: https://svnweb.freebsd.org/changeset/base/295759

Log:
  Remove a stray else. It isn't needed (due to the return at the end of
  the if statement it pairs with). While not an error today, a careless
  edit in the future could cause problems (though given the nature of
  this specific code, the problems quite likely would be some variation
  of "most direct access SCSI storage devices won't attach," which is
  unlikely to go unnoticed).
  
  PVS-Studio: V705

Modified:
  head/sys/cam/scsi/scsi_da.c

Modified: head/sys/cam/scsi/scsi_da.c
==============================================================================
--- head/sys/cam/scsi/scsi_da.c	Thu Feb 18 14:38:37 2016	(r295758)
+++ head/sys/cam/scsi/scsi_da.c	Thu Feb 18 15:12:52 2016	(r295759)
@@ -3228,7 +3228,8 @@ dadone(struct cam_periph *periph, union 
 					softc->state = DA_STATE_PROBE_RC;
 					xpt_schedule(periph, priority);
 					return;
-				} else
+				}
+
 				/*
 				 * Attach to anything that claims to be a
 				 * direct access or optical disk device,


More information about the svn-src-head mailing list