svn commit: r295719 - head/sys/dev/ata/chipsets

Gleb Smirnoff glebius at FreeBSD.org
Wed Feb 17 21:13:34 UTC 2016


Author: glebius
Date: Wed Feb 17 21:13:33 2016
New Revision: 295719
URL: https://svnweb.freebsd.org/changeset/base/295719

Log:
  Ternary operator has lower priority than OR.
  
  Found by:	PVS-Studio

Modified:
  head/sys/dev/ata/chipsets/ata-serverworks.c

Modified: head/sys/dev/ata/chipsets/ata-serverworks.c
==============================================================================
--- head/sys/dev/ata/chipsets/ata-serverworks.c	Wed Feb 17 21:09:19 2016	(r295718)
+++ head/sys/dev/ata/chipsets/ata-serverworks.c	Wed Feb 17 21:13:33 2016	(r295719)
@@ -162,9 +162,8 @@ ata_serverworks_chipinit(device_t dev)
 	}
     }
     else {
-	pci_write_config(dev, 0x5a,
-			 (pci_read_config(dev, 0x5a, 1) & ~0x40) |
-			 (ctlr->chip->cfg1 == SWKS_100) ? 0x03 : 0x02, 1);
+	pci_write_config(dev, 0x5a, (pci_read_config(dev, 0x5a, 1) & ~0x40) |
+	    ((ctlr->chip->cfg1 == SWKS_100) ? 0x03 : 0x02), 1);
     }
     ctlr->setmode = ata_serverworks_setmode;
     return 0;


More information about the svn-src-head mailing list