svn commit: r304221 - head/sys/boot/efi/boot1

[Emmanuel Vadot]

On Tue, 16 Aug 2016 12:16:30 -0600
Warner Losh <imp at bsdimp.com> wrote:

> On Tue, Aug 16, 2016 at 8:57 AM, Ed Schouten <ed at nuxi.nl> wrote:
> > Hi Emmanuel,
> >
> > 2016-08-16 16:23 GMT+02:00 Emmanuel Vadot <manu at freebsd.org>:
> >> Author: manu
> >> Date: Tue Aug 16 14:23:35 2016
> >> New Revision: 304221
> >> URL: https://svnweb.freebsd.org/changeset/base/304221
> >>
> >> Log:
> >>   Use %ju modifier for u_int64_t and %jd modifier for off_t.
> >>   off_t is long long on arm32 and long on amd64
> >
> > I think both of these should be solved differently:
> >
> > - For uint64_t, you can use <inttypes.h>'s PRIu64 in the formatting
> > string. In kernel space, I suspect you need to use something like
> > <machine/inttypes.h>.
> 
> cast it to intmax_t and use %jd. We've shunned PRIu64 in the tree.
> It's existing practice, but I'm sure bruce will voice mild distaste.
> 
> > - For off_t, it's all right to print it with %jd, but then be sure to
> > also add a cast to the argument itself. It may not necessarily be
> > equal to an intmax_t.
> 
> The cast is important.
> 
> Warner


 Thanks to all of you, I didn't know about PRI* (but I guess this was a
good thing to not know about them).

-- 
Emmanuel Vadot