svn commit: r304078 - head/sys/ddb

Bruce Evans bde at FreeBSD.org
Sun Aug 14 13:23:03 UTC 2016


Author: bde
Date: Sun Aug 14 13:23:02 2016
New Revision: 304078
URL: https://svnweb.freebsd.org/changeset/base/304078

Log:
  Don't print an extra newline after the instruction when printing for
  single stepping of multiple instructions (e.g., s/p,<count> and n/p).
  db_print_loc_and_inst() already prints a newline on all arches although
  it probably shouldn't.
  
  Especially on SMP systems, single stepping tends to deadlock or panic
  too quickly to be useful for anything except finding bugs in itself,
  but with printing "itself" includes console drivers so it is useful
  for generating stress tests for console drivers.

Modified:
  head/sys/ddb/db_run.c

Modified: head/sys/ddb/db_run.c
==============================================================================
--- head/sys/ddb/db_run.c	Sun Aug 14 13:17:59 2016	(r304077)
+++ head/sys/ddb/db_run.c	Sun Aug 14 13:23:02 2016	(r304078)
@@ -145,7 +145,6 @@ db_stop_at_pc(bool *is_breakpoint)
 		if (db_sstep_print) {
 		    db_printf("\t\t");
 		    db_print_loc_and_inst(pc);
-		    db_printf("\n");
 		}
 		return (false);	/* continue */
 	    }
@@ -165,7 +164,6 @@ db_stop_at_pc(bool *is_breakpoint)
 			for (i = db_call_depth; --i > 0; )
 			    db_printf("  ");
 			db_print_loc_and_inst(pc);
-			db_printf("\n");
 		    }
 		}
 		if (inst_call(ins))


More information about the svn-src-head mailing list