svn commit: r298247 - head/sbin/fdisk_pc98

[Pedro Giffuni]

On 04/19/16 22:06, Bruce Evans wrote:
> On Wed, 20 Apr 2016, Marcelo Araujo wrote:
>
>> 2016-04-20 0:16 GMT+08:00 John Baldwin <jhb at freebsd.org>:
>>
>>> On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote:
>>>> Author: araujo
>>>> Date: Tue Apr 19 04:46:13 2016
>>>> New Revision: 298247
>>>> URL: https://svnweb.freebsd.org/changeset/base/298247
>>>>
>>>> Log:
>>>>   Remove redundant parenthesis.
>>>>
>>>>   Submitted by:       pfg
>>>>   MFC after:  2 weeks.
>
> I don't realling like churnging to the nonstandard nitems().  Use
> of the nonstandard <sys/param.h> is bad enough.
>

TBH, I am not joyful about them either, however it does improve 
readability so it makes sense only in the cases where sys/param.h
is already in use.

One of the things I dislike is that most of the macros are in
lowercase. Lowercase would make sense if these were inline functions
but inline functions have disadvantages for these use cases.
OTOH, if they were uppercase, they would not be very easy on the eyes,
which is the current advantage.

No way out of it :(.

Pedro.