svn commit: r297762 - head/sys/dev/ichiic

Steven Hartland steven.hartland at multiplay.co.uk
Sat Apr 9 20:29:58 UTC 2016


Hi John, it would be nice if the commit message clarified why the change 
was made, as well as what was changed. This would allow others like 
myself to learn about the reasons for changes like this, which aren't 
self explanatory.

On 09/04/2016 21:18, John Baldwin wrote:
> Author: jhb
> Date: Sat Apr  9 20:18:34 2016
> New Revision: 297762
> URL: https://svnweb.freebsd.org/changeset/base/297762
>
> Log:
>    Use DELAY() instead of sleeping during boot-time attach.
>    
>    Tested by:	Wolfgang Zenker <wolfgang at lyxys.ka.sub.org>
>
> Modified:
>    head/sys/dev/ichiic/ig4_iic.c
>
> Modified: head/sys/dev/ichiic/ig4_iic.c
> ==============================================================================
> --- head/sys/dev/ichiic/ig4_iic.c	Sat Apr  9 20:05:39 2016	(r297761)
> +++ head/sys/dev/ichiic/ig4_iic.c	Sat Apr  9 20:18:34 2016	(r297762)
> @@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint3
>   			error = 0;
>   			break;
>   		}
> -		mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
> +		if (cold)
> +			DELAY(1000);
> +		else
> +			mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
>   	}
>   	return (error);
>   }
>



More information about the svn-src-head mailing list