svn commit: r297589 - head/usr.sbin/bhyve

Pedro F. Giffuni pfg at FreeBSD.org
Tue Apr 5 19:30:20 UTC 2016


Author: pfg
Date: Tue Apr  5 19:30:19 2016
New Revision: 297589
URL: https://svnweb.freebsd.org/changeset/base/297589

Log:
  bhyve: Remove unneeded variable ncq.
  
  ncq was not being inititialized properly but it was not actually
  necessary either, so make the code smaller by removing it.
  
  CID:		1248842
  Reviewed by:	grehan

Modified:
  head/usr.sbin/bhyve/pci_ahci.c

Modified: head/usr.sbin/bhyve/pci_ahci.c
==============================================================================
--- head/usr.sbin/bhyve/pci_ahci.c	Tue Apr  5 18:27:47 2016	(r297588)
+++ head/usr.sbin/bhyve/pci_ahci.c	Tue Apr  5 19:30:19 2016	(r297589)
@@ -427,7 +427,6 @@ ahci_port_stop(struct ahci_port *p)
 	struct ahci_ioreq *aior;
 	uint8_t *cfis;
 	int slot;
-	int ncq;
 	int error;
 
 	assert(pthread_mutex_isowned_np(&p->pr_sc->mtx));
@@ -445,10 +444,7 @@ ahci_port_stop(struct ahci_port *p)
 		if (cfis[2] == ATA_WRITE_FPDMA_QUEUED ||
 		    cfis[2] == ATA_READ_FPDMA_QUEUED ||
 		    cfis[2] == ATA_SEND_FPDMA_QUEUED)
-			ncq = 1;
-
-		if (ncq)
-			p->sact &= ~(1 << slot);
+			p->sact &= ~(1 << slot);	/* NCQ */
 		else
 			p->ci &= ~(1 << slot);
 


More information about the svn-src-head mailing list