svn commit: r288452 - head/sys/dev/drm2/i915

John Baldwin jhb at freebsd.org
Thu Oct 1 17:03:13 UTC 2015


On Thursday, October 01, 2015 04:59:08 PM John Baldwin wrote:
> Author: jhb
> Date: Thu Oct  1 16:59:07 2015
> New Revision: 288452
> URL: https://svnweb.freebsd.org/changeset/base/288452
> 
> Log:
>   Most error cases in i915_gem_do_execbuffer() jump to one of two labels to
>   release resources (such as unholding pages) when errors occur.  Some
>   recently added error checks return immediately instead of jumping to a
>   label resulting in leaks.  Fix these to jump to a label to do cleanup
>   instead.

I was getting panics due to the hold count on pages being negative in this
function.  The hold counts were quiet high and so I believe that the hold
count overflowed to zero due to these leaks and triggered the panic.

-- 
John Baldwin


More information about the svn-src-head mailing list