svn commit: r284107 - head/sys/cddl/compat/opensolaris/sys

[Jan Beich]

Andriy Gapon <avg at FreeBSD.org> writes:

> On 09/06/2015 13:31, Jan Beich wrote:
>
>> Andriy Gapon <avg at FreeBSD.org> writes:
>> 
>>> Author: avg Date: Sun Jun  7 08:54:25 2015 New Revision: 284107 URL:
>>> https://svnweb.freebsd.org/changeset/base/284107
>>> 
>>> Log: compat nvpair.h: make sure that the names are mangled only for
>>> kernel
>>> 
>>> Currently there is no good reason to mangle the userland API. The change
>>> was introduced in eac1d566b46edef765754203bef22c75c1699966, r279437.
>>> Also see https://reviews.freebsd.org/D1881.
>> 
>> Can you bump __FreeBSD_version? At least sysutils/geomWatch requires it.
>> 
>> https://svnweb.freebsd.org/changeset/ports/388906
>
> There should have been a bug report and an src fix instead of (parts of)
> https://svnweb.freebsd.org/ports?view=revision&revision=386870

Good point. However, opensolaris libs have unclear ABI guarantees. Their
API is not exposed but the libs aren't marked PRIVATELIB. Some symbols
are removed on updates *without* corresponding SHLIB_MAJOR bumps.
libnvpair is mostly unchanged between 8.4R and 11.0C, though.

  # shouldn't be possible without libzfs.so.2 in libmap.conf
  /poudriere/jails/84amd64/sbin/zfs: Undefined symbol "zpool_set_history_str"

> I wonder why the libnvpair ABI breakage was silently accepted but the ABI fix
> requires some special magic...

I'll probably back out ports at 386870 and ports at 388906 after a while.
libnvpair with bogus ABI existed on 11.0C for 3 months, enough to end up
in the binary snapshots a few times.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20150609/2ed49be8/attachment.sig>