svn commit: r283974 - head/lib/libugidfw

[Marcelo Araujo]

2015-06-04 16:29 GMT+08:00 NGie Cooper <yaneurabeya at gmail.com>:

> On Thu, Jun 4, 2015 at 12:41 AM, Konstantin Belousov
> <kostikbel at gmail.com> wrote:
> ...
> >> -     size = sizeof(rule);
> >>       error = sysctl(name, len, NULL, NULL, &rule, 0);
> > This is very strange chunk.  I suspect that the intent was to have 'size'
> > as the sixth argument to the sysctl(3) call, or just have sizeof(rule)
> > instead of 0.
>
> Agreed.
>

Agreed too, I have open another review request, because I have double check
and there are some missing prototypes too.


Best,
-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)