svn commit: r285692 - head/sys/dev/random

Mark R V Murray markm at FreeBSD.org
Sun Jul 19 17:25:44 UTC 2015


> On 19 Jul 2015, at 18:02, Konstantin Belousov <kostikbel at gmail.com> wrote:
> 
>> -		printf("random: %s unblock wait\n", __func__);
>> +		/* Only bother the console every 10 seconds or so */
>> +		if (spamcount == 0)
>> +			printf("random: %s unblock wait\n", __func__);
>> +		spamcount = (spamcount + 1)%100;
> Is ppsratecheck() not suitable for this due to use of > 1 sec period ?

Oooh! Very probably, thank you.

>> +		error = tsleep(&random_alg_context, PCATCH, "randseed", hz/10);
>> +		if ((error == ERESTART | error == EINTR))
> This is probably still valid, but I wonder if you mean || there.
> Then you could also remove extra ().

Oh, nuts. Got the wrong patch. Thank you.

> All your commits are breaking all style(9) rules.  It would be nice to keep
> the style at least for the files where you added random harvesting and which
> are already mostly style compliant.  E.g., what about wrapping lines at
> position somewhere between 72 and 80 ?

I’ll look, thanks!

M
-- 
Mark R V Murray



More information about the svn-src-head mailing list