svn commit: r286787 - head/sys/x86/x86

Roger Pau Monné royger at FreeBSD.org
Mon Aug 17 09:59:05 UTC 2015


El 16/08/15 a les 11.50, Konstantin Belousov ha escrit:
> On Sun, Aug 16, 2015 at 12:03:58PM +0300, Konstantin Belousov wrote:
>> On Sun, Aug 16, 2015 at 10:16:53AM +0200, Roger Pau Monn?? wrote:
>>> pmap_map_io_transient contains some of this logic, but it uses
>>> vmem_alloc (with M_WAITOK) instead of a pcpu pageframe, which defeats
>>> part of the purpose of this change and cannot be used as-is.
>>
>> This logic can be repeated, but it is probably too much for the purpose.
>> It would be enough to have single frame (we cannot reuse CMAP1),
>> protected by a spin mutex.  I do not see much sense in providing
>> optimized per-cpu frames for this case.
> 
> Like this.  I only compiled the patch.

Thanks, yes, this looks right. Since this is only used for the bounce
buffer code I don't think it's necessary to have a per-cpu frame. If the
usage of this function is expanded I might look into adding a per-cpu frame.

Roger.


More information about the svn-src-head mailing list