svn commit: r272649 - head/contrib/byacc

[Craig Rodrigues]

On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin <bapt at freebsd.org> wrote:

> On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote:
> > On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin <bapt at freebsd.org>
> wrote:
> >
> > >
> > > Why a direct commit instead of a proper import of 20141005 version? it
> > > would
> > > have imho been better, simpler and easier to maintain.
> > >
> >
> > Because according to Thomas Dickey, he did not fix all
> > the memory related problems in snapshot 20141005.  Specifically there are
> > still
> > some issues not fixed when realloc() is called.
> > I was going to wait for the next snapshot.
> > However, I wanted to get that one fix into FreeBSD to fix the kyua tests,
> > which have been failing under Jenkins.  See:
> > https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/
> > (see runs #10 and #11).
>
> In that case I will import the new one which has the fix (do you confirm?)
>

According to http://invisible-island.net/byacc/CHANGES.html , the
2014-10-06 has a fix
to address my concerns.  However, this fix involves a lot of changes to the
code,
and I don't have time right now to audit everything.

There have been a lot of changes to the byacc code in the past few days.
The changes
are good bugfixes, but I would recommend auditing everything beore
importing the snapshot into FreeBSD.
--
Craig