svn commit: r272405 - head/sys/fs/autofs

Edward Tomasz Napierala trasz at FreeBSD.org
Thu Oct 2 10:37:57 UTC 2014


Author: trasz
Date: Thu Oct  2 10:37:56 2014
New Revision: 272405
URL: https://svnweb.freebsd.org/changeset/base/272405

Log:
  Call uma_zfree() outside of lock, and improve comment.
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/fs/autofs/autofs.c

Modified: head/sys/fs/autofs/autofs.c
==============================================================================
--- head/sys/fs/autofs/autofs.c	Thu Oct  2 10:32:24 2014	(r272404)
+++ head/sys/fs/autofs/autofs.c	Thu Oct  2 10:37:56 2014	(r272405)
@@ -454,13 +454,13 @@ autofs_trigger_one(struct autofs_node *a
 	if (last) {
 		TAILQ_REMOVE(&autofs_softc->sc_requests, ar, ar_next);
 		/*
-		 * XXX: Is it safe?
+		 * Unlock the sc_lock, so that autofs_task() can complete.
 		 */
 		sx_xunlock(&autofs_softc->sc_lock);
 		taskqueue_cancel_timeout(taskqueue_thread, &ar->ar_task, NULL);
 		taskqueue_drain_timeout(taskqueue_thread, &ar->ar_task);
-		sx_xlock(&autofs_softc->sc_lock);
 		uma_zfree(autofs_request_zone, ar);
+		sx_xlock(&autofs_softc->sc_lock);
 	}
 
 	/*


More information about the svn-src-head mailing list