svn commit: r268491 - head/usr.bin/users

[Jilles Tjoelker]

On Sat, Jul 12, 2014 at 11:06:33PM +0200, Dimitry Andric wrote:
> On 10 Jul 2014, at 17:29, Ed Schouten <ed at 80386.nl> wrote:
> > On 10 July 2014 17:23, Pietro Cerutti <gahr at freebsd.org> wrote:
> >> It's because of the standard library. Examples:

> >> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a'
> >> [-Werror,-Wunused-parameter]
> >>        static void construct(allocator_type& __a, _Tp* __p)

> >> /usr/include/c++/v1/__functional_base:85:12: error: cast from 'const
> >> volatile char *' to 'wchar_t *' increases required alignment from 1 to 4
> >> [-Werror,-Wcast-align]
> >>    return (_Tp*)&reinterpret_cast<const volatile char&>(__x);

> > Then I would suggest that these specific warnings (-Wunused-parameter)
> > were to be disabled for C++ programs. The actual consumers should not
> > have to lower their WARNS, simply because the standard library is
> > broken.

> IMHO it is not broken at all, but for some reason we compile everything
> with -Wsystem-headers when WARNS=1 or higher. :-)

I think -Wsystem-headers makes sense (at least in C) because we maintain
the system headers as part of FreeBSD and therefore want to fix issues
in them as well.

If the C++ standard library has a lower quality level goal, then it may
be appropriate to disable -Wsystem-headers for C++ so at least the
programs themselves can use high WARNS.

-- 
Jilles Tjoelker