svn commit: r265020 - head/sys/arm/include

Ian Lepore ian at FreeBSD.org
Sun Apr 27 18:12:56 UTC 2014


Author: ian
Date: Sun Apr 27 18:12:55 2014
New Revision: 265020
URL: http://svnweb.freebsd.org/changeset/base/265020

Log:
  Remove cpu_idcache_wbinv_all() from kdb_cpu_trap(), it's no longer needed.
  
  This was added ca. 2004 for the purpose of ensuring the caches were in the
  right state after the debugger set a breakpoint.  kdb_cpu_sync_icache()
  was added in 2007 to handle that situation, and now the wbinv_all is
  actually harmful because the operation isn't broadcast to other cores.

Modified:
  head/sys/arm/include/kdb.h

Modified: head/sys/arm/include/kdb.h
==============================================================================
--- head/sys/arm/include/kdb.h	Sun Apr 27 17:41:18 2014	(r265019)
+++ head/sys/arm/include/kdb.h	Sun Apr 27 18:12:55 2014	(r265020)
@@ -55,8 +55,6 @@ kdb_cpu_sync_icache(unsigned char *addr,
 static __inline void
 kdb_cpu_trap(int type, int code)
 {
-
-	cpu_idcache_wbinv_all();
 }
 
 #endif /* _MACHINE_KDB_H_ */


More information about the svn-src-head mailing list