svn commit: r264677 - head/usr.bin/login

Jilles Tjoelker jilles at FreeBSD.org
Sat Apr 19 13:47:33 UTC 2014


Author: jilles
Date: Sat Apr 19 13:47:32 2014
New Revision: 264677
URL: http://svnweb.freebsd.org/changeset/base/264677

Log:
  login: Remove broken dialup log message.
  
  For 10 years, the "DIALUP <tty>, <user>" message has required having a
  hostname (-h) instead of not having a hostname; therefore, it is never
  logged. Given that dialup is obsolete and this has not been fixed, remove
  the log message.
  
  Note that LOGALL, which is defined by default, logs a message for all
  logins, including dialup logins.

Modified:
  head/usr.bin/login/login.c

Modified: head/usr.bin/login/login.c
==============================================================================
--- head/usr.bin/login/login.c	Sat Apr 19 12:38:01 2014	(r264676)
+++ head/usr.bin/login/login.c	Sat Apr 19 13:47:32 2014	(r264677)
@@ -489,14 +489,6 @@ main(int argc, char *argv[])
 		if (errno != EROFS)
 			syslog(LOG_ERR, "chown(%s): %m", ttyn);
 
-	/*
-	 * Exclude cons/vt/ptys only, assume dialup otherwise
-	 * TODO: Make dialup tty determination a library call
-	 * for consistency (finger etc.)
-	 */
-	if (hflag && isdialuptty(tty))
-		syslog(LOG_INFO, "DIALUP %s, %s", tty, pwd->pw_name);
-
 #ifdef LOGALL
 	/*
 	 * Syslog each successful login, so we don't have to watch


More information about the svn-src-head mailing list