svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ...

[Mark R V Murray]

On 13 Oct 2013, at 16:13, Konstantin Belousov <kostikbel at gmail.com> wrote:
> Surely this works, thank you. The rwfile.c content probably should be
> taken under the #ifdef RANDOM_RWFILE.

OK - thanks for the feedback!

> But I do not see much use for the randomdev_read_file() and
> randomdev_write_file() functions. It would be better to directly code
> the VFS calls in the random_harvestq_cache(). For one thing, it would
> eliminate unneccessary close and open of the entropy file.

There is some uncertainty about the future of that code, so I want
to keep it that way for now. Writing files from the kernel is making so@
very uncomfortable, and there is too much scope for error there.

We'll settle it down properly in 11.*.

M
-- 
Mark R V Murray

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 353 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20131013/a47e35b2/attachment.sig>