svn commit: r241625 - head/usr.sbin/cron/cron

[Konstantin Belousov]

On Mon, Oct 22, 2012 at 09:10:17AM -0700, Maxim Sobolev wrote:
> Guys,
> 
> The latest version of the patch against current HEAD is available here:
> 
> http://sobomax.sippysoft.com/cron.diff
> 
> Any comments/suggestions are appreciated. This version should default to 
> previous behaviour of waking up every 60 seconds unless there is 
> @every_second entry in the cron.
> 
> Konstantin, can you please put it for testing to your boxes? Please make 
> sure to do `make clean' after applying it, as libcron is not listed as a 
> dependency for cron, so it's possible that some changes may not be 
> picked up.

I patched the HEAD with the provided diff, and did make clean all in
usr.sbin/cron. The resulting binary correctly handled both /etc/crontab
and personal crontabs with the each-minute jobs.

I did not read the changed logic. Still, I suggest you to wrap the too-long
line in the patch. Also, it seems that the changes would benefit from
(extensive) commenting in the code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20121023/40f8f402/attachment.sig>