svn commit: r243665 - head/sbin/dump

[Eitan Adler]

On 29 November 2012 15:57, Konstantin Belousov <kostikbel at gmail.com> wrote:

> IMO, such changes shall not be done, and the already accumulated nonsense
> needs to be reverted.

It causes no harm, and helps reduce the number of false positives in
the clang static analyzer code so I fail to see why this should be
reverted.
This isn't akin to a comment as it changes the behavior of at least
one helpful tool.

Any future change which changed the return behavior of the function
would cause an error (due to -Werror) and then the attribute could be
changed.



-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams