svn commit: r235267 - in head/usr.bin/sort: . nls

Gabor Kovesdan gabor at FreeBSD.org
Fri May 11 13:09:11 UTC 2012


On 2012.05.11. 15:02, Colin Percival wrote:
> On 05/11/12 05:48, Konstantin Belousov wrote:
>> >On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote:
>>> >>+bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static
>>> >>unsigned char **cmonths = NULL;
>> >
>> >Such initializations are useless. You only increase the size of the binary
>> >on the disk as the consequence.
> I just tested this hypothesis, and found no change in binary size using
> either clang or gcc46.  Presumably they're smart enough to ignore explicit
> (and unnecessary) initializations of statics to zero.
Thanks Colin and thanks Konstantin for raising this doubt. I will clean 
these up later for better style, anyway.

Gabor



More information about the svn-src-head mailing list