svn commit: r233045 - in head/sys: conf kern
glebius at FreeBSD.org
Tue Mar 20 18:27:05 UTC 2012
On Tue, Mar 20, 2012 at 06:00:50PM +0100, Davide Italiano wrote:
D> 2012/3/20 Gleb Smirnoff <glebius at freebsd.org>:
D> > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote:
D> > D> >> These indented ifdefs look like a major violation of style used throughout
D> > D> >> the FreeBSD kernel code. Can you please keep with common style?
D> > D> >>
D> > D> >
D> > D> > Heh,
D> > D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and
D> > D> > after I'll have approval from my mentor I'll commit.
D> > Looks okay, apart from additional empty line in NOTES. Isn't single
D> > empty line enough?
D> > --
D> > Totus tuus, Glebius.
D> Well, I removed that in my previous commit.
D> It was a mistake.
D> But if you think it's ok to remove that line, I have no objections on this.
Well, I'm not that style(9)-evident person :) I just personally dislike
multiple empty lines, since less code fits on a terminal. So I won't insist
on any choice here.
I just noticed incorrect indentation of ifdefs, and that's all.
Totus tuus, Glebius.
More information about the svn-src-head