svn commit: r232570 - head/sys/boot/i386/boot2

John Baldwin jhb at freebsd.org
Tue Mar 6 15:39:56 UTC 2012


On Tuesday, March 06, 2012 6:34:42 am Dimitry Andric wrote:
> On 2012-03-05 20:53, John Baldwin wrote:
> > Author: jhb
> > Date: Mon Mar  5 19:53:17 2012
> > New Revision: 232570
> > URL: http://svn.freebsd.org/changeset/base/232570
> > 
> > Log:
> >   Fix boot2 to handle boot config files that only contain a custom path to
> >   a loader or kernel.  Specifically, kname cannot be pointed at cmd[] since
> >   it's value is change to be an empty string after the initial call to
> >   parse, and cmd[]'s value can be changed (thus losing a prior setting for
> >   kname) due to user input at the boot prompt.  While here, ensure that that
> >   initial boot config file text is nul-terminated, that ops is initialized
> >   to zero, and that kname is always initialized to a valid string.
> 
> Sigh, this broke building boot2 with clang again... :(

I only put back 1 of the memcpy's instead of 3 to try to make it as small as
possible. :(  The problem is the last round of changes to shrink it broke
functionality.

-- 
John Baldwin


More information about the svn-src-head mailing list