svn commit: r230354 - head/usr.sbin/makefs

[Eitan Adler]

On Sun, Jan 22, 2012 at 11:28 PM, Hiroki Sato <hrs at freebsd.org> wrote:
> ea> bug fix which could be upstreamed that would be great. On the other
> ea> hand I would like to continue with my goal of making the non-contrib
> ea> world compilable with CC=gcc46.
> ea>
> ea> Should I revert this commit?
>
>  I don't think it is needed.  The makefs utility is a special case
>  because it will probably diverge from the upstream to support
>  FreeBSD-specific feature in the future (this is one of the reasons
>  why it is not in contrib/).  It didn't happen so far, however.

Understood.

>  By the way, does gcc46 no longer allow unused code?

gcc46 enables -Wunused-but-set-variable enabled with -Wextra. One
possible solution is to just disable the warning, but IMHO having
random unused variables just makes code harder to understand.

It also enables a few other stricter checks for C conformance.

> Generally speaking, I think it is enough to clean up unused code only when we
>  actually change the code.

If these were style(9) or "best practice" cleanups - I'd agree.
However this was prompted by my specific goal of making the  userland
code compile with gcc46. It would be nice to see FreeBSD as compiler
agnostic as possible.

-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams