svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp...

[Ben Kaduk]

On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber <gjb at freebsd.org> wrote:
> On Fri, Dec 30, 2011 at 07:54:44PM +0000, Alexey Dokuchaev wrote:
>> On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote:
>> > On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <uqs at freebsd.org> wrote:
>> > > -                * is 11 bit wide that gives us upto 2048 chunks.
>> > > +                * is 11 bit wide that gives us up to 2048 chunks.
>> >
>> > Should be "11 bits", no?
>>
>> I'm not a native speaker, but I think "11 bit wide" is correct here.  I
>> could have probably got into specifics, but simple googling for "16 ton shit
>> dropped on me" yielded 525M results, while the same phrase with "tons" only
>> 18,9M.  :-^
>>
>
> Considering the full context, maybe it would be better written as:
>
> rsp_cs is an 11 bit wide field that gives ...

(I'm a native speaker, too.)

Were I to seriously wordsmith the comment, I would make it:
* The minimum L2CAP MTU is 43 bytes.  That means we need
* ceiling(65536 / 43) = 1525 chunks to transfer the maximum
* packet size with minimum MTU.  Since the "rsp_cs" field in
* fd_idx_t is 11 bits wide, that allows up to 2048 chunks which
* is more than sufficient.

But it may not be worth worrying about it this much.

-Ben