svn commit: r231026 - head/sys/powerpc/ofw
jhb at freebsd.org
Tue Feb 7 19:03:48 UTC 2012
On Monday, February 06, 2012 12:07:17 pm Nathan Whitehorn wrote:
> On 02/06/12 10:06, John Baldwin wrote:
> > On Monday, February 06, 2012 10:40:54 am Nathan Whitehorn wrote:
> >> On 02/06/12 06:53, John Baldwin wrote:
> >>> On Sunday, February 05, 2012 11:54:26 am Nathan Whitehorn wrote:
> >>>> Author: nwhitehorn
> >>>> Date: Sun Feb 5 16:54:26 2012
> >>>> New Revision: 231026
> >>>> URL: http://svn.freebsd.org/changeset/base/231026
> >>>> Log:
> >>>> Make sure to remap adjusted resources.
> >>> Hmm, I had considered remapping adjusted resources an invalid operation (i.e.
> >>> should fail with EINVAL). I believe that the NEW_PCIB code should only apply
> >>> this API to resources backing the resource windows in PCI-PCI bridges and that
> >>> those resources should never have RF_ACTIVE set. Are you seeing calls of it
> >>> for active resources?
> >> No, I was just trying to be safe here, since it wasn't clear that that
> >> was invalid. I'm happy to replace the contents of the if with return
> >> EINVAL or something.
> > Yeah, I would do that, perhaps with a KASSERT() as well so it panics in HEAD.
> How does this look? I've kept both the EINVAL and the KASSERT.
Looks good to me, thanks!
More information about the svn-src-head