svn commit: r234723 - in head/sys: amd64/amd64 amd64/include
i386/i386 i386/include pc98/pc98 sparc64/include
jhb at freebsd.org
Fri Apr 27 13:40:19 UTC 2012
On Thursday, April 26, 2012 4:24:25 pm Attilio Rao wrote:
> Author: attilio
> Date: Thu Apr 26 20:24:25 2012
> New Revision: 234723
> URL: http://svn.freebsd.org/changeset/base/234723
> Clean up the intr* MD KPI from the SMP dependency, removing a cause of
> discrepancy between modules and kernel, but deal with SMP differences
> within the functions themselves.
> As an added bonus this also helps in terms of code readability.
Hmm, this should not have affected anything with modules as no modules
should have ever called this. Also, making intr_bind() available for UP
kernels on x86 is largely pointless. It's only caller is already conditional
nexus_bind_intr(device_t dev, device_t child, struct resource *irq, int cpu)
return (intr_bind(rman_get_start(irq), cpu));
I think the UP stubs for intr_bind() should be removed. No drivers should
be using that directly (they should all use bus_bind_intr(9)). The same
appears to be true for sparc64 as well.
I had only noticed the intr_add_cpu() changes when I reviewed, not the
More information about the svn-src-head