svn commit: r226224 - head/sys/netinet

Gleb Smirnoff glebius at
Mon Oct 10 20:15:04 UTC 2011


On Mon, Oct 10, 2011 at 05:41:11PM +0000, Qing Li wrote:
Q> Author: qingli
Q> Date: Mon Oct 10 17:41:11 2011
Q> New Revision: 226224
Q> Log:
Q>   All indirect routes will fail the rtcheck, except for a special host
Q>   route where the destination IP and the gateway IP is the same. This
Q>   special case handling is only meant for backward compatibility reason.
Q>   The last commit introduced a bug in the route check logic, where a
Q>   valid special case is treated as an error. This patch fixes that bug
Q>   along with some code cleanup.
Q>   Suggested by:	gleb
Q>   Reviewed by:	kmacy, discussed with gleb
Q>   MFC after:	1 day

  Looks like you have committed a slightly different patch to stable/8
in r226230. Is that okay?

  Also, you haven't awaited even one day, while our policy suggests at
least 3 days before MFC, and 3 days is actually a delay for critical

P.S. Now I am not the only Gleb at community. Recently
Gleb Kurtsou joined us, and his login name is exactly "gleb", while
mine is "glebius". So, your commit may be confusing to later
reviewers of VCS history.

Totus tuus, Glebius.

More information about the svn-src-head mailing list