svn commit: r227843 - in head/sys: amd64/amd64 arm/econa arm/mv
arm/xscale/i80321 arm/xscale/i8134x arm/xscale/ixp425 dev/aac
dev/acpica dev/amr dev/arcmsr dev/bce dev/bfe dev/bge ...
avg at FreeBSD.org
Tue Nov 22 21:53:05 UTC 2011
on 22/11/2011 23:28 Marius Strobl said the following:
> Author: marius
> Date: Tue Nov 22 21:28:20 2011
> New Revision: 227843
> URL: http://svn.freebsd.org/changeset/base/227843
> - There's no need to overwrite the default device method with the default
> one. Interestingly, these are actually the default for quite some time
> (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9)
> since r52045) but even recently added device drivers do this unnecessarily.
Maybe because it is not immediately obvious which methods do have sensible
defaults and which do not (and why). Thus, copy+paste.
E.g. bus_add_child vs bus_print_child below.
> Modified: head/sys/dev/acpi_support/acpi_wmi.c
> --- head/sys/dev/acpi_support/acpi_wmi.c Tue Nov 22 21:22:06 2011 (r227842)
> +++ head/sys/dev/acpi_support/acpi_wmi.c Tue Nov 22 21:28:20 2011 (r227843)
> @@ -175,7 +175,6 @@ static device_method_t acpi_wmi_methods[
> /* bus interface */
> DEVMETHOD(bus_add_child, bus_generic_add_child),
> - DEVMETHOD(bus_print_child, bus_generic_print_child),
> /* acpi_wmi interface */
More information about the svn-src-head