svn commit: r227483 - head/usr.sbin/portsnap/portsnap

[Alfred Perlstein]

* Garrett Cooper <yanegomi at gmail.com> [111112 19:25] wrote:
> On Nov 12, 2011, at 7:18 PM, Alfred Perlstein wrote:
> 
> > Author: alfred
> > Date: Sun Nov 13 03:18:57 2011
> > New Revision: 227483
> > URL: http://svn.freebsd.org/changeset/base/227483
> > 
> > Log:
> >  Utilize shell's IFS instead of forking ~6 processes to
> >  handle splitting input files on a '|'.  This greatly
> >  reduces the time taken to process several databases
> >  during the update process.
> > 
> >  Additionally add some more debug logging.
> > 
> > Modified:
> >  head/usr.sbin/portsnap/portsnap/portsnap.sh
> > 
> 
> 	Wouldn't
> 
> oldIFS=$IFS
> # Blah blah
> IFS=$oldIFS
> 
> 	be better?

Meh, it's hard to do it in some of the code because of the
'return' in the middle of the logic and in the other places
I didn't really care that much.

That said, I'll happily take a patch to clean it up some.

Just watch the logic, it's hairy in the places I used
'local'.

-- 
- Alfred Perlstein
.- VMOA #5191, 03 vmax, 92 gs500, 85 ch250, 07 zx10
.- FreeBSD committer