svn commit: r222094 - head/share/misc

[Ulrich Spörlein]

On Sun, 22.05.2011 at 20:16:47 +1000, Edwin Groothuis wrote:
> 
> On 22/05/2011, at 7:29 PM, Ulrich Spörlein wrote:
> 
> > On Thu, 19.05.2011 at 13:09:39 +0000, Edwin Groothuis wrote:
> >> Author: edwin
> >> Date: Thu May 19 13:09:39 2011
> >> New Revision: 222094
> >> URL: http://svn.freebsd.org/changeset/base/222094
> >> 
> >> Log:
> >>  Put AN back after finding out that tzsetup(1) will complain that
> >>  it doesn't exist. It will be removed again once the tzdata distribution
> >>  files have been updated with the replacements for AN.
> > 
> > Wouldn't it be better to have tzsetup use iso3166.tab from the tzdata
> > distribution, which is mostly guaranteed to be in sync with zone.tab?
> 
> 
> Which opens a different can of worms.
> Duplicate file, with semi-similar contents.
> 
> Whenever there are changes in the distribution of the tzdata iso3166.tab equivalent file, I check if they are in the /usr/share/misc equivalent file.
> A warning to that file should be added that tzsetup uses it and that they always should check tzsetup functionality before commiting it.

This seems way too brittle, as can be seen by random people going in and
updating our iso3166 file. I'd rather take a tiny duplication of files
than manual fixups needed to unbreak installing.

AFAICS only tzsetup and sysinstall depend on /usr/share/misc/iso3166,
if we change tzsetup to use the iso list from tzdata and since
sysinstall is on the chopping block we could then simply remove our
iso3166 list.

And as for duplicated files, have you looked at regdomain.xml and
ieee80211_regdomain.h? Just saying ...

Uli