svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys

Robert Watson rwatson at FreeBSD.org
Sat May 21 22:31:27 UTC 2011


On Sat, 21 May 2011, Robert Watson wrote:

> In fact, the code I pointed at in my previous e-mail will probably panic in 
> that case, since it improperly dereferences the inpcb's socket field without 
> first testing for NULL.

Or, looking more closely, only because the locking is broken, as it does test 
inp_socket.  However, it really shouldn't need to -- we try quite hard never 
to dereference inp_socket in the firewall code for this reason.  Hence, among 
other things, propagating so_cred down as inp_cred.

Robert


More information about the svn-src-head mailing list