svn commit: r219894 - head/sys/dev/ath/ath_hal/ar5416

Adrian Chadd adrian at
Wed Mar 23 03:58:55 UTC 2011

Author: adrian
Date: Wed Mar 23 03:58:55 2011
New Revision: 219894

  The AR5416+ chips all have MIB counters (which the AR5416 ANI code assumes)
  so there's no need to enable the RX of invalid frames just to do ANI.
  The if_ath code and AR5212 ANI code setup the RX filter bits to enable
  receiving OFDM/CCK errors if the device doesn't have the hardware
  MIB counters. It isn't initialising it for the AR5416+ because all of
  those chips have hardware MIB counters.
  This fixes the odd (and performance affecting!) situation where if ani
  is enabled (via sysctl dev.ath.X.intmit) then suddenly there's be a very
  large volume of phy errors - which is good to track, but not what was
  intended. Since each PHY error is a received (0 length) frame, it can
  significantly tie up the RX side of things.


Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_ani.c
--- head/sys/dev/ath/ath_hal/ar5416/ar5416_ani.c	Wed Mar 23 02:47:04 2011	(r219893)
+++ head/sys/dev/ath/ath_hal/ar5416/ar5416_ani.c	Wed Mar 23 03:58:55 2011	(r219894)
@@ -310,14 +310,10 @@ ar5416AniControl(struct ath_hal *ah, HAL
 			ahp->ah_procPhyErr &= ~HAL_ANI_ENA;
 			/* Turn off HW counters if we have them */
-			ar5212SetRxFilter(ah,
-				ar5212GetRxFilter(ah) &~ HAL_RX_FILTER_PHYERR);
 		} else {			/* normal/auto mode */
 			/* don't mess with state if already enabled */
 			if (ahp->ah_procPhyErr & HAL_ANI_ENA)
-			ar5212SetRxFilter(ah,
-				ar5212GetRxFilter(ah) &~ HAL_RX_FILTER_PHYERR);
 			/* Enable MIB Counters */
 			enableAniMIBCounters(ah, ahp->ah_curani != AH_NULL ?
 			    ahp->ah_curani->params: &ahp->ah_aniParams24 /*XXX*/);

More information about the svn-src-head mailing list