svn commit: r223262 - in head:
contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config
contrib/binutils/ld contrib/binutils/opcodes contr...
brde at optusnet.com.au
Sat Jun 18 14:36:09 UTC 2011
On Sat, 18 Jun 2011, Ben Laurie wrote:
> Author: benl
> Date: Sat Jun 18 13:56:33 2011
> New Revision: 223262
> URL: http://svn.freebsd.org/changeset/base/223262
> Fix clang warnings.
> Approved by: philip (mentor)
Most of these seem to be bugs in clang, so source code can only be broken
by avoiding the warnings there. In particular:
- casting to void is a large style bug in gnu code. Warnings in vendor
code shouldn't be fixed anyway.
- it is an old gcc bug to warn about use of the extremely unsurprising
precedence of AND operators over OR operators. This bug is not much
of a problem since it is controlled by -Wparentheses. -Wparentheses
is impiled by -Wall, which is enables at WARNS >= 2. But it is a new
clang bug to make this warning unconditional (it can be turned off or
configured off, but this is not supported in FreeBSD or documented in
clang.1). So it is now fatal at WARNS >=1, since WARNS >=1 turns
warnings into errors.
More information about the svn-src-head