svn commit: r217048 - head/share/man/man9

Edward Tomasz Napierała trasz at freebsd.org
Thu Jan 6 09:32:36 UTC 2011


Wiadomość napisana przez Julian Elischer w dniu 2011-01-06, o godz. 10:02:
> On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote:
>> Author: trasz
>> Date: Thu Jan  6 08:33:48 2011
>> New Revision: 217048
>> URL: http://svn.freebsd.org/changeset/base/217048
>> 
>> Log:
>>   Get rid of bad advice regarding /* NOTREACHED */.  Compilers don't
>>   really need it (one can use __dead2 instead), and style(9) was not
>>   even consistent with itself in this regard.
>> 
>> Modified:
>>   head/share/man/man9/style.9
>> 
>> Modified: head/share/man/man9/style.9
>> ==============================================================================
>> --- head/share/man/man9/style.9	Thu Jan  6 08:13:30 2011	(r217047)
>> +++ head/share/man/man9/style.9	Thu Jan  6 08:33:48 2011	(r217048)
>> @@ -470,9 +470,6 @@ statement that cascade should have a
>>  .Li FALLTHROUGH
>>  comment.
>>  Numerical arguments should be checked for accuracy.
>> -Code that cannot be reached should have a
>> -.Li NOTREACHED
>> -comment.
> 
> I object STRONGLY to this change.
> 
> The NOTREACHED is also to help the reader understand what has happened and as an afterthought
> was also useful in LINT.  I know know of no technological change to the average reader that makes
> it less useful.

What about adding something like this?

Code that cannot be reached for non-obvious reasons may have
.Li NOTREACHED
comment.

--
If you cut off my head, what would I say?  Me and my head, or me and my body?



More information about the svn-src-head mailing list