svn commit: r218238 - head/sys/dev/ath

[Peter Jeremy]

On 2011-Feb-04 09:23:01 -0700, Warner Losh <imp at bsdimp.com> wrote:
>On 02/03/2011 16:07, Bruce Cran wrote:
>> On Thu, Feb 03, 2011 at 08:26:26PM +0000, Adrian Chadd wrote:
>>>   		if (ni != NULL) {
>>> +#if NOTYET
>>>   		/* tag AMPDU aggregates for reorder processing */
>> This seems to have broken the build because NOTYET isn't defined.
>
>ANSI C states that all undefined preprocessor variables shall expand to 
>0.  If we have a warning on that complains, we should turn it off.

Well, bde@ considers it a style bug so from that point of view, the
warning is useful.  Also,  given that the normal way of stating that
is "#ifdef NOTYET", keeping the warning may help catch code where
the preprocessor variable was supposed to have been defined but has
been misspelt - consider "#if _FreeBSD_version > 800100".

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20110205/d1e24641/attachment.pgp