svn commit: r221059 - in head/sys: kern sys

Kostik Belousov kostikbel at gmail.com
Tue Apr 26 11:53:41 UTC 2011


On Tue, Apr 26, 2011 at 01:44:00PM +0200, Hans Petter Selasky wrote:
> On Tuesday 26 April 2011 13:39:56 Konstantin Belousov wrote:
> > +       pending = !!callout_stop(&timeout_task->c);
> 
> pending = (callout_stop(&timeout_task->c) != 0);
> 
> ?

This line is about conversion from a boolean value to {0, 1} value set.
If !! construct does not look stylish, then wouldn't we need to go
with
	pending = (callout_stop(&timeout_task->c) != 0) ? 1 : 0;
instead ?

Feel free to adjust whatever variant you prefer and commit it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20110426/cf84c22f/attachment.pgp


More information about the svn-src-head mailing list