svn commit: r213744 - head/bin/sh

David O'Brien obrien at FreeBSD.org
Wed Oct 13 22:20:25 UTC 2010


On Wed, Oct 13, 2010 at 03:29:27PM +1100, Bruce Evans wrote:
> Add __noinline or whatever attributes to STATIC (but keep static in
> it) for the DEBUG >= 3 case if you are going that far.  __noinline
> should be a syntax error for variables, so this should also find any
> STATICs still on variables.  The spelling fix of changing STATIC to
> what it actually means
> (ASSORTED_HACKS_FOR_DEBUGGING_BUT_NOW_ONLY_FOR_FUNCTIONS) goes too far
> for me.

I've make all uses "static".  Otherwise we have some of the functions and
variable "STATIC" (if from 4.4BSD), and some others "static" (added later
by FreeBSD).  Surely this inconsistency isn't desired.

-- 
-- David  (obrien at FreeBSD.org)


More information about the svn-src-head mailing list