svn commit: r213791 - head/sys/cddl/compat/opensolaris/kern

Rui Paulo rpaulo at FreeBSD.org
Wed Oct 13 17:13:43 UTC 2010


Author: rpaulo
Date: Wed Oct 13 17:13:43 2010
New Revision: 213791
URL: http://svn.freebsd.org/changeset/base/213791

Log:
  Pass a format string to panic() and to taskqueue_start_threads().
  
  Found with:	clang

Modified:
  head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c
  head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c

Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c
==============================================================================
--- head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c	Wed Oct 13 17:12:23 2010	(r213790)
+++ head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c	Wed Oct 13 17:13:43 2010	(r213791)
@@ -48,7 +48,7 @@ vcmn_err(int ce, const char *fmt, va_lis
 		panic("Solaris: unknown severity level");
 	}
 	if (ce == CE_PANIC)
-		panic(buf);
+		panic("%s", buf);
 	if (ce != CE_IGNORE)
 		vprintf(buf, adx);
 }

Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c
==============================================================================
--- head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c	Wed Oct 13 17:12:23 2010	(r213790)
+++ head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c	Wed Oct 13 17:13:43 2010	(r213791)
@@ -73,7 +73,7 @@ taskq_create(const char *name, int nthre
 	tq = kmem_alloc(sizeof(*tq), KM_SLEEP);
 	tq->tq_queue = taskqueue_create(name, M_WAITOK, taskqueue_thread_enqueue,
 	    &tq->tq_queue);
-	(void) taskqueue_start_threads(&tq->tq_queue, nthreads, pri, name);
+	(void) taskqueue_start_threads(&tq->tq_queue, nthreads, pri, "%s", name);
 
 	return ((taskq_t *)tq);
 }


More information about the svn-src-head mailing list