svn commit: r213472 - head/tools/build/mk
Alexander Leidinger
netchild at FreeBSD.org
Thu Oct 7 09:58:52 UTC 2010
Quoting Doug Barton <dougb at FreeBSD.org> (from Wed, 06 Oct 2010
11:15:00 -0700):
> On 10/6/2010 12:49 AM, Alexander Leidinger wrote:
>> Author: netchild
>> Date: Wed Oct 6 07:49:28 2010
>> New Revision: 213472
>> URL: http://svn.freebsd.org/changeset/base/213472
>>
>> Log:
>> Add some missing files to optionally delete.
>>
>> Submitted by: Paul B Mahol<onemda at gmail.com>
>>
>> Modified:
>> head/tools/build/mk/OptionalObsoleteFiles.inc
>>
>> Modified: head/tools/build/mk/OptionalObsoleteFiles.inc
>> ==============================================================================
>> --- head/tools/build/mk/OptionalObsoleteFiles.inc Wed Oct 6
>> 07:34:41 2010 (r213471)
>> +++ head/tools/build/mk/OptionalObsoleteFiles.inc Wed Oct 6
>> 07:49:28 2010 (r213472)
>> @@ -141,6 +141,7 @@ OLD_FILES+=usr/share/man/man8/authpf.8.g
>> .endif
>>
>> .if ${MK_BIND} == no
>> +OLD_FILES+=etc/periodic/daily/470.status-named
>
>
> Traditionally we haven't deleted these. In the case of named-related
> files I would prefer that we did not because:
>
> 1. That check is off by default
> 2. If the user is not running named it won't do any harm
> 3. The default for installing named from the ports is to continue to
> use the infrastructure in the base (such as this script, and
> /etc/rc.d/named).
>
> I'm not sure what the right answer for all the periodic scripts is,
> but for this one I would like it not to be included in the obsolete
> files.
Please confirm that this file is installed during installworld when
MK_BIND is equal to "no" (as I read it, it is not installed).
I agree that it makes sense to keep this file (and at least one which
is covered by the sendmail knob), but the design of "delete-old" is to
remove everything which is not installed anymore (= the file has to be
deleted if MK_BIND is equal to "no").
If the script is installed during installworld (= I haven't read the
Makefile correctly), the script is not allowed to be deleted (and the
above piece of the patch is wrong = pointyhat to me). If the script is
not installed during installworld, the above patch is 100% correct and
the delete-old is working as designed.
If you do not want to have it deleted by delete-old, do not exclude it
during installworld (you have my vote for this) and remove its entry
from OptionalObsoleteFiles.inc.
Bye,
Alexander.
--
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Postmen never die, they just lose their zip.
More information about the svn-src-head
mailing list