svn commit: r213398 - head/bin/rm

[Alexander Best]

On Mon Oct  4 10, Pawel Jakub Dawidek wrote:
> On Mon, Oct 04, 2010 at 02:35:54PM +0400, Dmitry Morozovsky wrote:
> > On Mon, 4 Oct 2010, Alexander Best wrote:
> > 
> > AB> On Mon Oct  4 10, Pawel Jakub Dawidek wrote:
> > AB> > On Mon, Oct 04, 2010 at 06:17:46AM +0000, Xin LI wrote:
> > AB> > > Author: delphij
> > AB> > > Date: Mon Oct  4 06:17:45 2010
> > AB> > > New Revision: 213398
> > AB> > > URL: http://svn.freebsd.org/changeset/base/213398
> > AB> > > 
> > AB> > > Log:
> > AB> > >   Clarify the combination effect of -P and -f to make it clear.
> > AB> > 
> > AB> > While you're at it, it would be nice to add a note that this doesn't
> > AB> > work with all file systems. In case of eg. ZFS the data won't be
> > AB> > overwritten.
> > AB> 
> > AB> isn't this detail already being covered by the existing note in the BUGS
> > AB> section?
> > AB> 
> > AB>      "The -P option assumes that the underlying file system is a fixed-block
> > AB>      file system.  UFS is a fixed-block file system, LFS is not.  In addition,
> > AB>      only regular files are overwritten, other types of files are not."
> > 
> > Maybe s/LFS/ZFS/ then, as LFS is no more relevant for FreeBSD users while ZFS 
> > now is?
> 
> That's what I thought too.

good point. ZFS should really be added to the list and LFS should go away. are
there any other relevant filesystems without a fixed-block size that need to be
mentioned? what about afs? or tmpfs?

also: is this really something belonging into a BUGS section? personally i
think the BUGS section in rm(1) should be renamed to CAVEATS.

cheers.
alex

> 
> -- 
> Pawel Jakub Dawidek                       http://www.wheelsystems.com
> pjd at FreeBSD.org                           http://www.FreeBSD.org
> FreeBSD committer                         Am I Evil? Yes, I Am!



-- 
a13x