svn commit: r213401 - head/sys/sys

Poul-Henning Kamp phk at FreeBSD.org
Mon Oct 4 10:48:48 UTC 2010


Author: phk
Date: Mon Oct  4 10:48:47 2010
New Revision: 213401
URL: http://svn.freebsd.org/changeset/base/213401

Log:
  Certain static code analysis tools (FlexeLint being one) are very
  suspicious about 'l' and '1' being confused in numeric constants.
  The fear being that some old fart programmer might still think that
  he is using a Remmington Noiseless as input terminal device.
  
  An easy way to placate this fear is to use capital 'L' or to put
  the 'u' in unsigned constants in front of the 'l'.

Modified:
  head/sys/sys/time.h

Modified: head/sys/sys/time.h
==============================================================================
--- head/sys/sys/time.h	Mon Oct  4 07:00:47 2010	(r213400)
+++ head/sys/sys/time.h	Mon Oct  4 10:48:47 2010	(r213401)
@@ -95,11 +95,11 @@ bintime_mul(struct bintime *bt, u_int x)
 {
 	uint64_t p1, p2;
 
-	p1 = (bt->frac & 0xffffffffllu) * x;
+	p1 = (bt->frac & 0xffffffffull) * x;
 	p2 = (bt->frac >> 32) * x + (p1 >> 32);
 	bt->sec *= x;
 	bt->sec += (p2 >> 32);
-	bt->frac = (p2 << 32) | (p1 & 0xffffffffllu);
+	bt->frac = (p2 << 32) | (p1 & 0xffffffffull);
 }
 
 #define	bintime_clear(a)	((a)->sec = (a)->frac = 0)


More information about the svn-src-head mailing list