svn commit: r215259 - head/sbin/ifconfig

Marius Strobl marius at FreeBSD.org
Sat Nov 13 21:03:20 UTC 2010


Author: marius
Date: Sat Nov 13 21:03:19 2010
New Revision: 215259
URL: http://svn.freebsd.org/changeset/base/215259

Log:
  When printing media with more than one media option set aggregate these
  in a comma delimited list instead of repeating "mediaopt" for each one.
  This matches how the options of the active media are printed with
  print_media_word() and brings us in line what NetBSD does.
  
  MFC after:	2 weeks

Modified:
  head/sbin/ifconfig/ifmedia.c

Modified: head/sbin/ifconfig/ifmedia.c
==============================================================================
--- head/sbin/ifconfig/ifmedia.c	Sat Nov 13 20:45:16 2010	(r215258)
+++ head/sbin/ifconfig/ifmedia.c	Sat Nov 13 21:03:19 2010	(r215259)
@@ -757,7 +757,7 @@ print_media_word_ifconfig(int ifmw)
 {
 	struct ifmedia_description *desc;
 	struct ifmedia_type_to_subtype *ttos;
-	int i;
+	int seen_option = 0, i;
 
 	/* Find the top-level interface type. */
 	desc = get_toptype_desc(ifmw);
@@ -792,7 +792,10 @@ print_media_word_ifconfig(int ifmw)
 		for (desc = ttos->options[i].desc;
 		    desc->ifmt_string != NULL; desc++) {
 			if (ifmw & desc->ifmt_word) {
-				printf(" mediaopt %s", desc->ifmt_string);
+				if (seen_option == 0)
+					printf(" mediaopt ");
+				printf("%s%s", seen_option++ ? "," : "",
+				    desc->ifmt_string);
 			}
 		}
 	}


More information about the svn-src-head mailing list