svn commit: r214961 - head/usr.bin/yacc

David O'Brien obrien at FreeBSD.org
Mon Nov 8 20:11:43 UTC 2010


On Sun, Nov 07, 2010 at 05:54:20PM -0800, Juli Mallett wrote:
> On Sun, Nov 7, 2010 at 15:22, David E. O'Brien <obrien at freebsd.org> wrote:
> > Author: obrien
> > Date: Sun Nov  7 23:22:42 2010
> > New Revision: 214961
> > URL: http://svn.freebsd.org/changeset/base/214961
> >
> > Log:
> >  Directly use memory allocation functions and remove needless casts in
> >  their usage.  Also use associated modern types instead of k&r ones.
> 
> You do know that changing skeleton.c affects the generated files,
> right?

Yes Juli, I know how byacc works.

> I'm wondering if whatever sed script you're
> judiciously-applying knows that.  C++ does not do implicit conversions
> from "void *" so you need the casts on the mallocs there.

The changes I made were tested on building several other applications.

> With a C++ compiler:

But as you indirectly point out -- they were all C applications.

-- 
-- David  (obrien at FreeBSD.org)


More information about the svn-src-head mailing list