svn commit: r208632 - head/sys/pc98/pc98
Takahashi Yoshihiro
nyan at FreeBSD.org
Sat May 29 03:06:57 UTC 2010
Author: nyan
Date: Sat May 29 03:06:56 2010
New Revision: 208632
URL: http://svn.freebsd.org/changeset/base/208632
Log:
MFi386: revision 208604
Clarify a potential issue in get_fpcontext() use.
Modified:
head/sys/pc98/pc98/machdep.c
Modified: head/sys/pc98/pc98/machdep.c
==============================================================================
--- head/sys/pc98/pc98/machdep.c Sat May 29 02:14:05 2010 (r208631)
+++ head/sys/pc98/pc98/machdep.c Sat May 29 03:06:56 2010 (r208632)
@@ -563,6 +563,13 @@ sendsig(sig_t catcher, ksiginfo_t *ksi,
sf.sf_uc.uc_mcontext.mc_gs = rgs();
bcopy(regs, &sf.sf_uc.uc_mcontext.mc_fs, sizeof(*regs));
sf.sf_uc.uc_mcontext.mc_len = sizeof(sf.sf_uc.uc_mcontext); /* magic */
+
+ /*
+ * The get_fpcontext() call must be placed before assignments
+ * to mc_fsbase and mc_gsbase due to the alignment-override
+ * code in get_fpcontext() that possibly clobbers 12 bytes of
+ * mcontext after mc_fpstate.
+ */
get_fpcontext(td, &sf.sf_uc.uc_mcontext);
fpstate_drop(td);
/*
@@ -2455,6 +2462,13 @@ get_mcontext(struct thread *td, mcontext
mcp->mc_esp = tp->tf_esp;
mcp->mc_ss = tp->tf_ss;
mcp->mc_len = sizeof(*mcp);
+
+ /*
+ * The get_fpcontext() call must be placed before assignments
+ * to mc_fsbase and mc_gsbase due to the alignment-override
+ * code in get_fpcontext() that possibly clobbers 12 bytes of
+ * mcontext after mc_fpstate.
+ */
get_fpcontext(td, mcp);
sdp = &td->td_pcb->pcb_gsd;
mcp->mc_fsbase = sdp->sd_hibase << 24 | sdp->sd_lobase;
More information about the svn-src-head
mailing list