svn commit: r208119 - head/sys/dev/isp

[Matthew Jacob]

On 5/15/2010 8:17 PM, Rob Farmer wrote:
> On Sat, May 15, 2010 at 1:26 PM, Matt Jacob<mjacob at freebsd.org>  wrote:
>    
>> Author: mjacob
>> Date: Sat May 15 20:26:10 2010
>> New Revision: 208119
>> URL: http://svn.freebsd.org/changeset/base/208119
>>
>> Log:
>>   Whap. Hook up some wires that were forgotten a few months ago and restore
>>   the zombie device timeout code and the loop down time code and the fabric
>>   hysteresis code.
>>   MFC after:    1 week
>>   Sponsored By: Panasas
>>
>> Modified:
>>   head/sys/dev/isp/isp_freebsd.c
>>   head/sys/dev/isp/ispvar.h
>>
>>      
> Hi,
>
> I haven't seen anything from the tinderbox but I am getting a build
> failure after this change. This is i386 in vmware:
>
> ===>  isp (all)
> cc -O2 -fno-strict-aliasing -pipe -fomit-frame-pointer -march=prescott
> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> -DHAVE_KERNEL_OPTION_HEADERS -include
> /usr/obj/usr/src/sys/CORETWO/opt_global.h -I. -I@ -I@/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common  -I/usr/obj/usr/src/sys/CORETWO
>   -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx
> -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding
> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -c
> /usr/src/sys/modules/isp/../../dev/isp/isp.c
> cc -O2 -fno-strict-aliasing -pipe -fomit-frame-pointer -march=prescott
> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> -DHAVE_KERNEL_OPTION_HEADERS -include
> /usr/obj/usr/src/sys/CORETWO/opt_global.h -I. -I@ -I@/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common  -I/usr/obj/usr/src/sys/CORETWO
>   -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx
> -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding
> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -c
> /usr/src/sys/modules/isp/../../dev/isp/isp_library.c
> cc -O2 -fno-strict-aliasing -pipe -fomit-frame-pointer -march=prescott
> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> -DHAVE_KERNEL_OPTION_HEADERS -include
> /usr/obj/usr/src/sys/CORETWO/opt_global.h -I. -I@ -I@/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common  -I/usr/obj/usr/src/sys/CORETWO
>   -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx
> -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding
> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -c
> /usr/src/sys/modules/isp/../../dev/isp/isp_target.c
> cc -O2 -fno-strict-aliasing -pipe -fomit-frame-pointer -march=prescott
> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> -DHAVE_KERNEL_OPTION_HEADERS -include
> /usr/obj/usr/src/sys/CORETWO/opt_global.h -I. -I@ -I@/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common  -I/usr/obj/usr/src/sys/CORETWO
>   -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx
> -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding
> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -c
> /usr/src/sys/modules/isp/../../dev/isp/isp_freebsd.c
> cc1: warnings being treated as errors
> /usr/src/sys/modules/isp/../../dev/isp/isp_freebsd.c: In function 'isp_gdt':
> /usr/src/sys/modules/isp/../../dev/isp/isp_freebsd.c:3946: warning:
> format '%lu' expects type 'long unsigned int', but argument 5 has type
> 'time_t'
> /usr/src/sys/modules/isp/../../dev/isp/isp_freebsd.c: In function 'isp_async':
> /usr/src/sys/modules/isp/../../dev/isp/isp_freebsd.c:5068: warning:
> format '%lu' expects type 'long unsigned int', but argument 6 has type
> 'time_t'
> *** Error code 1
>    

Grumble. Thanks.